Skip to content
This repository was archived by the owner on Jul 15, 2022. It is now read-only.

Conversation

@benbrimeyer
Copy link

@benbrimeyer benbrimeyer commented Apr 7, 2022

I'm back from #4.

Adds the following methods to Dictionary:

  • updateIn(dictionary, keyPath, updater, notSetValue)
  • getIn(dictionary, keyPath, default)
  • setIn(dictionary, keyPath, newValue)
  • removeIn(dictionary, keyPath)

Implementations and test cases are similar to Immutable.js's implementations of these methods.

Todo:

  • Implementation
  • Write tests
  • Make sure this is something we would want to add
  • Documentation

@benbrimeyer
Copy link
Author

@freddylist Should I proceed with this PR? I'd like to get the greenlight that this is something worth contributing.

@freddylist
Copy link
Owner

Hello, thanks for the PR!

Any new features to Llama are probably not worth pursuing at the moment; I have just updated the readme with a notice that I will no longer be maintaining Llama.

If it's ok with you, I will just leave this PR hanging. :)

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants