Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing because of directories… #13

Closed
evantravers opened this issue May 15, 2013 · 18 comments
Closed

Failing because of directories… #13

evantravers opened this issue May 15, 2013 · 18 comments
Assignees
Labels
Milestone

Comments

@evantravers
Copy link

I'm not sure how to post this one… I'm actually assuming I'm doing something wrong. Running middleman s3_sync currently generates this error:

/gems/middleman-s3_sync-3.0.11/lib/middleman/s3_sync/resource.rb:139:in `read': Is a directory - build/articles/ (Errno::EISDIR)

EDIT: (accidentally hit submit) I'm using activate directory_indexes or whatever… but removing it doesn't change anything apparently. I'm quite confused.

@ghost ghost assigned fredjean May 15, 2013
@fredjean
Copy link
Owner

Do you have an articles.gz file in your build directory?

@evantravers
Copy link
Author

No… it's the folder containing my blog's post.

@fredjean
Copy link
Owner

I'll add a check to see whether it is a directory. They should have already been filtered out.

Just out of curiosity, could you send me a directory listing of what is under build?

@evantravers
Copy link
Author

Sure… here you go.

@fredjean
Copy link
Owner

I'm stomped... The code that figures out what paths to look at should weed out directories. I'll have to go through it to make sure that I haven't missed anything...

@evantravers
Copy link
Author

I don't have my blog on github… but it is on bitbucket. Would it be helpful to poke through it? Like I said… I have probably done something wrong.

Evan Travers
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, May 16, 2013 at 10:08 AM, Frederic Jean wrote:

I'm stomped... The code that figures out what paths to look at should weed out directories. I'll have to go through it to make sure that I haven't missed anything...


Reply to this email directly or view it on GitHub (#13 (comment)).

@fredjean
Copy link
Owner

I think it would help a lot, if only to see how the path made it there. Also, what OS are you running this on?

I'm (now) fredjean_ on bitbucket.

@evantravers
Copy link
Author

I'm on OSX… just invited you to the repo. Thanks for your expert help and making this really useful plugin.

Evan Travers
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, May 16, 2013 at 10:16 AM, Frederic Jean wrote:

I think it would help a lot, if only to see how the path made it there. Also, what OS are you running this on?
I'm (now) fredjean_ on bitbucket.


Reply to this email directly or view it on GitHub (#13 (comment)).

@fredjean
Copy link
Owner

Bingo! I found where the directory names came from and I can now fix it.

Your bucket had objects in place for the directories in your blog. I'll add some code that remove anything that ends with a / from the remote bucket.

I don't think that it was anything that you did wrong...

@evantravers
Copy link
Author

A winner is you. Well done man!

@fredjean
Copy link
Owner

I also made a few fixes to the styles so the blog would build... Pushing to your repo in a few moments...

@fredjean
Copy link
Owner

Actually, I'll need to do a pull request...

@evantravers
Copy link
Author

I think I just granted you push access… but a pull request will be fine.

Evan Travers
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, May 16, 2013 at 11:12 AM, Frederic Jean wrote:

Actually, I'll need to do a pull request...


Reply to this email directly or view it on GitHub (#13 (comment)).

@fredjean
Copy link
Owner

And the pull request has been sent.

@evantravers
Copy link
Author

Thanks dood… one weird thing that trips me out (and may have tripped you) is that master isn't magic at all on bitbucket… so you made the changes to panoramas. Weird stuff. I'll sort it out. Thanks a ton.

@fredjean
Copy link
Owner

I did notice that the branch name was a little odd… I did push the site to S3, you might need to push master up as well...

Frederic Jean
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, May 16, 2013 at 10:24 AM, Evan Travers wrote:

Thanks dood… one weird thing that trips me out (and may have tripped you) is that master isn't magic at all on bitbucket… so you made the changes to panoramas. Weird stuff. I'll sort it out. Thanks a ton.


Reply to this email directly or view it on GitHub (#13 (comment)).

@fredjean
Copy link
Owner

Most of the commits were pretty granular. You should be able to cherry pick them into master without issues...

@evantravers
Copy link
Author

Yeah… you are a much better git man than I. I was going to move panoramas onto master anyway… (makes a total wreck). Totally worked in the end though. Thanks so much!

Evan Travers
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, May 16, 2013 at 11:51 AM, Frederic Jean wrote:

Most of the commits were pretty granular. You should be able to cherry pick them into master without issues...


Reply to this email directly or view it on GitHub (#13 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants