Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If MACOSX_EMBEDDED is there, use it for plist #317

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

baconpaul
Copy link
Collaborator

MACOSX_EMBEDDED_ allows you to embed a clap as a subordinate framework of your wrapped component, but we didn't use that handed in clap to generate the Plist. Fix that by using it if available.

MACOSX_EMBEDDED_ allows you to embed a clap as a subordinate
framework of your wrapped component, but we didn't use that
handed in clap to generate the Plist. Fix that by using it
if available.
@baconpaul
Copy link
Collaborator Author

Want some testing before merge.

@CrushedPixel
Copy link

CrushedPixel commented Oct 10, 2024

Doesn't work for me, no matter if I specify MACOSX_EMBEDDED_CLAP_LOCATION or even AUV2_MACOSX_EMBEDDED_CLAP_LOCATION (just to try it)

Usage:

  set(AUV2_TARGET ${PROJECT_NAME}_auv2)
  add_library(${AUV2_TARGET} MODULE)
  message(path=${CLAP_PLUGIN_PATH})
  target_add_auv2_wrapper(
      TARGET ${AUV2_TARGET}
      MACOSX_EMBEDDED_CLAP_LOCATION ${CLAP_PLUGIN_PATH}
      AUV2_MACOSX_EMBEDDED_CLAP_LOCATION ${CLAP_PLUGIN_PATH}
      OUTPUT_NAME "${PROJECT_NAME}"
  )

prints

path=/Users/marius/Documents/CLAPPlugins/nih-plug/target/bundled/gain.clap
[...]
CMake Error at _deps/clap-wrapper-src/cmake/wrap_auv2.cmake:115 (message):
  clap-wrapper: For nontarget build specify AUV2 subtype code (4 chars)
Call Stack (most recent call first):
  CMakeLists.txt:31 (target_add_auv2_wrapper)

@CrushedPixel
Copy link

I confirm that this does indeed actually work now.

@baconpaul
Copy link
Collaborator Author

Great I’ll push it to next.

@baconpaul baconpaul merged commit e6a09e9 into free-audio:next Oct 11, 2024
19 checks passed
@baconpaul baconpaul deleted the use-embedded-clap-for-plist branch October 11, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants