As a user, I can search using the search bar in the navigation (implemented with PostgreSQL queries)

[QuincyLarson]

As a user I should be able to search through through chapters.

• Mock-up search bar in Material UI (Revert "Mock search bar with Material UI. refs #349 (#409)" #414) as seen in homepage mock-up
• Implement results query or API call
• Implement results view with lazy load, or infinity scroll, or pagination

[allella]

The backend logic of this has been discussed on #112

[xarielx]

@Zeko369 please let me know if you need help setting this up, are you planning to use Axios? We can coordinate at any time after 5 pm eastern time if you need help. Thanks

[Zeko369]

We're not using axios, we have our own server/client implementation with cross-fetch.

This should be a part of fetchEvents on homepage, so you would actually want to use a redux store for it and everything.
But for simplicity you can just use cross-fetch and useState to query some events according to the search param for example api/v1/events?serach=FooBar

This is more of a API issue, I'll handle it in a today, but for now you can stub it.

[xarielx]

That makes perfect sense. I was including useState into waft I was coding but wasn’t sure if we were tying it to the pre loaded events or all the ones saved on the back end UF ID: 0903-9139<tel:0903-9139> On Feb 27, 2020, at 3:55 AM, Fran Zekan <notifications@github.com> wrote:  [External Email] We're not using axios, we have our own server/client implementation<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_freeCodeCamp_chapter_blob_master_client_services_http-2Dservice.ts&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=RjXmsQnc1Nqs3ON4MiC_jP_ja-8LDMlGR5rK5BQhg4k&m=XbcwwTc8atwTSlIW4x2GD9v8m-iwkMdkgKPSYMTIfwM&s=XRPAm78ol94L7RYfKOBW6cXx7-XfXqCdGsr8_N0XhRo&e=> with cross-fetch. This should be a part of eventsQuery on homepage, so you would actually want to create a redux store for it and everything. But for simplicity you can just use cross-fetch and useState to query some events according to the search param for example api/v1/events?serach=FooBar This is more of a API issue, I'll handle it in a today, but for now you can stub it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_freeCodeCamp_chapter_issues_349-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAIV6GAEDKMHBRPKQ7COVY4LRE55V5A5CNFSM4KZ5EOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDQEHQ-23issuecomment-2D591856158&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=RjXmsQnc1Nqs3ON4MiC_jP_ja-8LDMlGR5rK5BQhg4k&m=XbcwwTc8atwTSlIW4x2GD9v8m-iwkMdkgKPSYMTIfwM&s=JMwnAyKgf39kRNbqexlCoYpHi7EiWbIQSJs9EONQ-NA&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIV6GAAUUOK3BK7WVRADPA3RE55V5ANCNFSM4KZ5EOYQ&d=DwMCaQ&c=sJ6xIWYx-zLMB3EPkvcnVg&r=RjXmsQnc1Nqs3ON4MiC_jP_ja-8LDMlGR5rK5BQhg4k&m=XbcwwTc8atwTSlIW4x2GD9v8m-iwkMdkgKPSYMTIfwM&s=Jr9_BpAPHSFFQSpheAQTzlYIdhhwmrkuG2uIxCImvMc&e=>.

[allella]

Here's a visual of the search bar in the navigation on the homepage mock-up.

[allella]

#414 and the feat/search has much of the search bar mocked up in Material UI

[Ravichandra-C]

@Zeko369 Can I work on this issue?

[Zeko369]

@Ravichandra-C Hop on it

[Ravichandra-C]

@ojeytonwilliams @allella @Zeko369 , Should this be implemented with Full text search of Postgres? If not , Could you please guide me on how the backend logic for search api should be implemented?

[allella]

I'll defer to Oliver or the earlier contributors on how to approach this one.

[Zeko369]

@Ravichandra-C this project switched to prisma in the meantime, and there is a preview feature in prisma (needs to be enabled but then works) that allows you to do full-text-search from JS without writing any raw SQL.

Take a look prisma docs for the feature

[ojeytonwilliams]

That's awesome, thanks for sharing it @Zeko369

@Ravichandra-C if you want to go ahead with this, go for it. It's a bit risky to rely on a preview feature, but if there are issues with search it won't render Chapter unusable.

[ojeytonwilliams]

In the interests of getting the MVP done, I think this can move to Nice to Have. It's 100% a feature we want, but we can see how Chapter functions without it first and focus on discovery once we have something to discover.

@allella do you remember the approach re: Roadmap and so on? I was wondering if we should have MVP and Roadmap issues both open, but mutually exclusive. Right now we have some Roadmap issues like #434 which are finished and one #264 that is both MVP and Roadmap. This is a little counter-intuitive.

[allella]

@ojeytonwilliams Quincy was tagging with Roadmap and closing to avoid the noise of having open issues.

I suppose we'd just re-open a subset of issues from the Roadmap when they are ready for implementation.

For the two issues you mentioned, I've re-tagged them to fit the pattern.

[ojeytonwilliams]

So: closed Roadmap = nice to have, but for the future, open Roadmap = nice to have, and worth implementing if someone is interested, but low priority

Is that about right?

[allella]

We moved the Search feature to the Roadmap since there will initially be about 10 fCC chapters testing the first iteration of the application.

@ojeytonwilliams Roadmap has been used to track issues which we want to at least come back to and not forget. So, there's no rating, but we can remove issues from the Roadmap on a future review.