Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

add globalstyles and minimal css reset #148

Conversation

ThomasRoest
Copy link
Contributor

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the master branch of Chapter.

Adds a globalstyles component with a minimal reset. Any other ideas/improvements welcome ofcourse!

Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🎉, just minor suggestions.
We should also correct properties like the inline-block display not defined in IE6/7/8/9. Thoughts?
Also, address the font-family inconsistency between 'textarea' and other form elements

pages/_app.tsx Show resolved Hide resolved
iframe,
img,
object,
video {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add the following tags:

article,
aside,
details,
figcaption,
figure,
footer,
header,
hgroup,
nav,
section,
summary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by adding these elements? Do they need some reset in some form?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about IE6/7/8/9. I don't think we should bother supporting those browsers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a browser support conversation on #144.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by adding these elements? Do they need some reset in some form?

Yes, I meant adding reset rules for the mentioned tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not necessary

Co-Authored-By: Vaibhav Singh <singh.vaibhav2011@gmail.com>
@vkWeb
Copy link
Member

vkWeb commented Oct 29, 2019

@ThomasRoest We are going to use Material-UI so we don't need to add reset styles explicitly. <CssBaseline /> will do the job for us: https://material-ui.com/components/css-baseline/

@vaibhavsingh97
Copy link
Member

@ThomasRoest We are going to use Material-UI so we don't need to add reset styles explicitly. <CssBaseline /> will do the job for us: material-ui.com/components/css-baseline

I don't know if I am missing anything, but have we reached the conclusion that which UI framework we will use?

@vkWeb
Copy link
Member

vkWeb commented Oct 30, 2019

@vaibhavsingh97 Quincy finalized it: #47 (comment)

@vaibhavsingh97
Copy link
Member

Awesome!! thanks @vkWeb 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants