This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Added frontend Input Field Validations on the EventForm.tsx and Enabled validations in app.ts #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added type to input component in the Event form page 2.removed the DefaultValue prop from input component since it is already getting set via UseForm react hook 3. changed the type of UrL and Video URL to url
|
|
added 3 commits
September 17, 2021 11:59
1. Updated cypress tests to match the role of type=number of Capacity 2. Changed the query for start_at and ends_at
1. Added decorators for URL and Video URL fields 2. Enabled Validations in app.ts
1.Added Get instaed of find to query starts_at and ends_at 2.Added 5 sec wait time for event to save
Ravichandra-C
changed the title
ojeytonwilliams
suggested changes
Sep 17, 2021
There was a problem hiding this comment.
Thanks a ton for this @Ravichandra-C. I found a couple of minor things, but it's looking great.
1. removed validate:tru from app.ts as it is default value 2. changed the location function from get to findbyLabelText in cypress test
ojeytonwilliams
approved these changes
Sep 17, 2021
|
@Zeko369 this looks solid to me, but do you want to take a look? |
|
Let's move things along. Thanks again for putting this together @Ravichandra-C! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md).mainbranch of Chapter.Closes #430
2.removed the DefaultValue prop from input component since it is already
getting set via UseForm react hook