This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Added functionality to send Email to selected Group of People #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i. Server 1. resolver.ts Modified the sendEventInvite Resolver to take an emailGroup as optional argument. ii. Client 1. Added New argument in method definitions in graphql.tsx 2. Created a new Modal component to shoqw the checkboxes for seleting the group 3. Added a button in Actions components to show the Modal componenet
|
|
ojeytonwilliams
suggested changes
Sep 24, 2021
There was a problem hiding this comment.
Hey @Ravichandra-C, I just want to start by saying this some really nice work. I know that I've nitpicked quite a bit, but that's all it is.
Anyways, thanks again for all your hard work and I hope the review comments make sense.
client/src/modules/dashboard/Events/components/SendEmailModal.tsx
Outdated
Show resolved
Hide resolved
client/src/modules/dashboard/Events/components/SendEmailModal.tsx
Outdated
Show resolved
Hide resolved
client/src/modules/dashboard/Events/components/SendEmailModal.tsx
Outdated
Show resolved
Hide resolved
client/src/modules/dashboard/Events/components/SendEmailModal.tsx
Outdated
Show resolved
Hide resolved
client/src/modules/dashboard/Events/components/SendEmailModal.tsx
Outdated
Show resolved
Hide resolved
client/src/modules/dashboard/Events/components/SendEmailModal.tsx
Outdated
Show resolved
Hide resolved
1. sendEmailModal.tsx 1. Created the Interface of FormInputs 2. Used the interface in useForm 3. renamed the metho to atleastOneChecked 4. Removed the Extra error message in atleastonechecked 5. Removed defaultChecked 2. resolver.ts 1. Added the strict type Checking in emailGroups Parameter 2. Removed the console.log
|
@ojeytonwilliams ,Thanks a lot for your feedback. I've made all the suggested changes except the part in server/src/controllers/Events/resolver.ts where we are using interested . Please let me know your thoughts on this. |
ojeytonwilliams
suggested changes
Sep 27, 2021
client/src/modules/dashboard/Events/components/SendEmailModal.tsx
Outdated
Show resolved
Hide resolved
|
@ojeytonwilliams , I've updated the message in Modal . Can you please review it once? |
ojeytonwilliams
approved these changes
Sep 27, 2021
|
Nice work, @Ravichandra-C, let's get this in 🚀 |
|
Ooops, misclicked 🤦♂️ |
|
@all-contributors add @Ravichandra-C for code |
|
I've put up a pull request to add @Ravichandra-C! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md).mainbranch of Chapter.Closes #99
i. Server
ii. Client
1. Added New argument in method definitions in graphql.tsx
2. Created a new Modal component to show the checkboxes for
selecting the group
3. Added a button in Actions components to show the Modal
component