Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): add comments to getter/setter instructions codeblock #94

Merged
merged 1 commit into from
Jul 1, 2018
Merged

fix(challenges): add comments to getter/setter instructions codeblock #94

merged 1 commit into from
Jul 1, 2018

Conversation

CharmedSatyr
Copy link
Contributor

Description

Added comments to indicate what console.log does in the instructional code block.

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #92

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 9e9bc27 into freeCodeCamp:dev Jul 1, 2018
@scissorsneedfoodtoo
Copy link
Contributor

👍 👍 Awesome! Everything LGTM 👍 👍

Thank you for your PR to fix this issue, @CharmedSatyr. We look forward to your next contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES6 getter/setter challenge console.logs should show results in comments
2 participants