Bonfire MDN links - Issue #255 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vote for inclusion. I also like your coding style @aldraco. |
|
LGTM |
|
Thanks! Great, I'll keep going with the rest of the bonfires. |
|
Are you going to them here or in a separate PR? |
| @@ -2,7 +2,8 @@ var _ = require('lodash'), | |||
| debug = require('debug')('freecc:cntr:bonfires'), | |||
| Bonfire = require('./../models/Bonfire'), | |||
| User = require('./../models/User'), | |||
| resources = require('./resources'); | |||
| resources = require('./resources') | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@aldraco Separate PR's are fine. If you can fix the comma typo we can merge it in. |
|
Voila! |
|
I've QA'd this and it is an immediate improvement on our Bonfires. I'm going to go ahead and get this into production tonight! Thanks so much @aldraco! and @BerkeleyTrue and @elimisteve for your feedback. |
QuincyLarson
pushed a commit
that referenced
this pull request
Mar 29, 2015
Bonfire MDN links - Issue #255
raisedadead
pushed a commit
that referenced
this pull request
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links for the one-flame bonfires have been added. I can continue with the rest or leave it here, up to you.
If there are no links to show, the "helpful links" header does not display.
TODO? I can also add an input on the "create bonfire" page to allow a user to add these at time of creation.