Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed title, it was totally wrong #31365

Closed
wants to merge 1 commit into from
Closed

changed title, it was totally wrong #31365

wants to merge 1 commit into from

Conversation

victorvisart
Copy link

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@RandellDawson RandellDawson added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label May 13, 2019
@RandellDawson RandellDawson added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Aug 7, 2019
@RandellDawson
Copy link
Member

RandellDawson commented Aug 7, 2019

@victoralloza Thank you for creating this PR. However, since it was created, the underlying document has changed. Can you please review and resolve the current merge conflicts? It could be the changes to the underlying document are so significant that your changes are no longer relevant. If the latter is the case, it might be easier to just close this PR and create a new PR with any changes you still feel are important to make.

If you need any assistance or have questions about resolving the merge conflicts, please reply back or contact someone in the Contributors Room on Gitter.

Thank you.

@QuincyLarson
Copy link
Contributor

We are restructuring a lot of the code and learning resources referenced in your pull request, so for now I am going to go ahead and close this pull request. Thanks again for opening this pull request and for contributing to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: merge conflict To be applied to PR's that have a merge conflict and need updating status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants