Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): update final option scoring description #55808

Merged

Conversation

TofikE124
Copy link
Contributor

Closes #55761

Summary:
Updated the description of the challenge to correctly reflect the requirement for updating the final option with a score of 0 when neither condition is true.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Aug 10, 2024
@gikf
Copy link
Member

gikf commented Aug 10, 2024

Hi there,

Thanks for creating this pull request.

The linked issue has not been triaged yet, and a solution has not been agreed upon. Once the issue is open for contribution, you are welcome to update this pull request to reflect the issue consensus. Until the issue is open for contribution, we will not be able to review your pull request.

@gikf gikf added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. javascript course These are for issues dealing with the current project based JS curriculum labels Aug 10, 2024
@gikf gikf added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels Aug 20, 2024
@Sembauke Sembauke merged commit a49fca2 into freeCodeCamp:main Aug 20, 2024
23 checks passed
@gikf
Copy link
Member

gikf commented Aug 20, 2024

Hi @TofikE124. Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript course These are for issues dealing with the current project based JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dice game (js beta) - step 7 incorrect instructions
3 participants