-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Conversation
c310ede
to
e2f6cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor questions about some behavior - otherwise we can get this merged asap 👍
@@ -10,4 +10,6 @@ This is a stub. <a href='https://github.com/freecodecamp/guides/tree/master/src/ | |||
<!-- The article goes here, in GitHub-flavored Markdown. Feel free to add YouTube videos, images, and CodePen/JSBin embeds --> | |||
|
|||
#### More Information: | |||
[Jupyter/IPython Notebook Quick Start Guide](http://jupyter-notebook-beginner-guide.readthedocs.io/en/latest/what_is_jupyter.html) | |||
<!-- Please add any articles you think might be helpful to read before writing the article --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, looks like there was only a link added to this stub, that the Normalise script removes. Should we add it back, or will this keep happening until the stub language is replaced with an article?
@@ -1,7 +1,7 @@ | |||
--- | |||
title: AVL Trees | |||
title: Avl Trees |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes AVL
to Avl
- do we need to update a proper nouns list or somehow mark that the all-caps version is the right way to display this?
src/pages/csharp/xaml/index.md
Outdated
@@ -1,6 +1,15 @@ | |||
--- | |||
title: XAML | |||
title: Xaml | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as the AVL
title re capitalization 😄
@HKuz all three review notes are linked to the same issue I had with this. Normalise looks for The articles on AVL and XAML, and five others, still had stubs in the file and were re-written. I managed to catch these as the diff was quite obvious. Thank you for taking the time to QA this as thoroughly as you have, I'll make the changes shortly. |
LGTM!! 🤙 ☎️ 🎵Thanks @Bouncey - that's good to know about the stub being re-written so we don't just merge in added links without some form of an article to go with it 👍 I've been meaning to dig into the scripts more to better understand the site, maybe a weekend activity while reviewing a couple hundred PRs or so... 😆 |
No description provided.