Skip to content
This repository has been archived by the owner on Aug 28, 2019. It is now read-only.

Normalise Articles 25Oct17 #4932

Merged
merged 6 commits into from
Oct 26, 2017
Merged

Normalise Articles 25Oct17 #4932

merged 6 commits into from
Oct 26, 2017

Conversation

Bouncey
Copy link
Member

@Bouncey Bouncey commented Oct 25, 2017

No description provided.

Copy link
Member

@HKuz HKuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor questions about some behavior - otherwise we can get this merged asap 👍

@@ -10,4 +10,6 @@ This is a stub. <a href='https://github.com/freecodecamp/guides/tree/master/src/
<!-- The article goes here, in GitHub-flavored Markdown. Feel free to add YouTube videos, images, and CodePen/JSBin embeds -->

#### More Information:
[Jupyter/IPython Notebook Quick Start Guide](http://jupyter-notebook-beginner-guide.readthedocs.io/en/latest/what_is_jupyter.html)
<!-- Please add any articles you think might be helpful to read before writing the article -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, looks like there was only a link added to this stub, that the Normalise script removes. Should we add it back, or will this keep happening until the stub language is replaced with an article?

@@ -1,7 +1,7 @@
---
title: AVL Trees
title: Avl Trees
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes AVL to Avl - do we need to update a proper nouns list or somehow mark that the all-caps version is the right way to display this?

@@ -1,6 +1,15 @@
---
title: XAML
title: Xaml
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the AVL title re capitalization 😄

@Bouncey
Copy link
Member Author

Bouncey commented Oct 26, 2017

@HKuz all three review notes are linked to the same issue I had with this.

Normalise looks for 'This is a stub... in the file via a RegEx. If found, the entire file is re-stubbed. This behaviour was intended, allowing us to update all stubs if the template stub changed for any reason.

The articles on AVL and XAML, and five others, still had stubs in the file and were re-written. I managed to catch these as the diff was quite obvious.

Thank you for taking the time to QA this as thoroughly as you have, I'll make the changes shortly.

@HKuz
Copy link
Member

HKuz commented Oct 26, 2017

LGTM!! 🤙 ☎️ 🎵

Thanks @Bouncey - that's good to know about the stub being re-written so we don't just merge in added links without some form of an article to go with it 👍 I've been meaning to dig into the scripts more to better understand the site, maybe a weekend activity while reviewing a couple hundred PRs or so... 😆

@HKuz HKuz merged commit 9f5c926 into freeCodeCamp:master Oct 26, 2017
@HKuz HKuz mentioned this pull request Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants