-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: podcast episode preview content #1177
fix: podcast episode preview content #1177
Conversation
mobile-app/lib/ui/widgets/podcast_widgets/podcast_tilte_widget.dart
Outdated
Show resolved
Hide resolved
Links won't be clickable anymore, we should probably use the HTML widget, despite the text being longer than 3 lines. |
ok, the link is only clickable if it has 'href" tag only, some of the links are not in href tag. |
I think that's fine as this is just a preview of the what the episode has to offer. The clickable links and more details can be seen in the respective episode view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The analyzer has reported some errors in your code. You can view them by running flutter analyze
. Also where are you making these changes from as they seem to be somehow bypassing the pre-commit check.
Checklist:
Update index.md
)Removed HTML widget because of maxLines property did not work as expected if the content contains elements like line breaks or other block-level elements that can break the line. That's why I added the text widget, by parsing the body of the description used as textcontent in the widget. By using the text widget we can see max lines 3
Closes #1175