Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing required programs on some of ATFs own tests #31

Closed
brd opened this issue Mar 23, 2017 · 2 comments
Closed

Missing required programs on some of ATFs own tests #31

brd opened this issue Mar 23, 2017 · 2 comments

Comments

@brd
Copy link
Member

brd commented Mar 23, 2017

In atf/libatf-c++/Kyuafile, the following tests should have:

atf_test_program{name="atf_c++_test", required_programs="c++"} atf_test_program{name="check_test", required_programs="cc"} atf_test_program{name="macros_test", required_programs="c++"}

Same in atf/libatf-c/Kyuafile:

atf_test_program{name="atf_c_test", required_programs="cc"} atf_test_program{name="check_test", required_programs="cc"} atf_test_program{name="macros_test", required_programs="cc"}

Thanks

@brd
Copy link
Member Author

brd commented Jul 12, 2017

Ping?

jmmv added a commit that referenced this issue Jul 22, 2017
Make the build and header test cases list the C and C++ compilers in
their require.progs metadata property.

Fixes #31.
@jmmv
Copy link
Member

jmmv commented Jul 22, 2017

It's not that simple unfortunately, because the compiler can be parameterized both at build time and at run time. I've just pushed a possible fix to the issue-31 branch and if it comes back as clean, I'll merge it.

@jmmv jmmv closed this as completed in b74133c Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants