Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amdgpu: reintroduce green_sardine and sienna_cichlid firmware #23

Closed
wants to merge 2 commits into from
Closed

Conversation

xmhd
Copy link

@xmhd xmhd commented May 7, 2022

This PR addresses #21
Also addresses freebsd/drm-kmod#155

This firmware was previously included, but was removed due to 'module names being too long to be processed by kldxref (see: 0382c95)'. This has apparently been fixed in 13.1 + 14.0, and the firmware is required for Cezanne APU's to work on 5.10 (previously worked on 5.7 with Renoir firmware as they are closely related).

I believe the next missing piece of the puzzle is adding the relevant bits to the Makefile in the gpu-firmware-kmod port.

xmhd added 2 commits May 7, 2022 10:50
This firmware is required by Cezanne APU's.
Previously removed due to "produced name is too long and kldxref fails".
0382c95
Previously removed due to "produced name is too long and kldxref fails".
0382c95
@evadot
Copy link
Contributor

evadot commented May 7, 2022

That will still fails on < 13.1 so we need to exclude them there.

@xmhd
Copy link
Author

xmhd commented May 7, 2022

That will still fails on < 13.1 so we need to exclude them there.

I'll add this and update the PR.

edit: OSMAJOR or OSVERSION for the version check?

@asas1asas200
Copy link

Does it need to add green_sardine*.bin files in amdgpukmsfw-files directory?
I have tried this PR on my FreeBSD 14.0-CURRENT but failed when make green_sardine_asd.bin.

The error message is below:

make[2]: don't know how to make /usr/home/zeng/Desktop/drm-kmod-firmware/amdgpukmsfw/green_sardine_asd/../../amdgpukmsfw-files/green_sardine_asd.bin. Stop

So I think the *.bin files about green_sardine should be put in amdgpukmsfw-files, and it can be found in Linux Kernel firmware(but I'm not sure if it existed in v5.10).

@xmhd
Copy link
Author

xmhd commented May 11, 2022

Does it need to add green_sardine*.bin files in amdgpukmsfw-files directory? I have tried this PR on my FreeBSD 14.0-CURRENT but failed when make green_sardine_asd.bin.

The error message is below:

make[2]: don't know how to make /usr/home/zeng/Desktop/drm-kmod-firmware/amdgpukmsfw/green_sardine_asd/../../amdgpukmsfw-files/green_sardine_asd.bin. Stop

So I think the *.bin files about green_sardine should be put in amdgpukmsfw-files, and it can be found in Linux Kernel firmware(but I'm not sure if it existed in v5.10).

Good catch - this will indeed need done.

I'm traveling tomorrow so probably not able to work on this, but I'll do it afterwards.

@evadot
Copy link
Contributor

evadot commented May 11, 2022

Not needed anymore.

@evadot evadot closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants