-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update x11 ports #273
base: main
Are you sure you want to change the base?
Update x11 ports #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I've tested x11/libwacom update via CTH-470 under x11-wm/sway-devel. For x11-servers/xorg-server you may want to take a look at updating x11-drivers/xf86-input-wacom as well.
GNU_CONFIGURE_MANPREFIX removal (after 9fd7ee1) is unrelated to the updates, so should be explicitly documented in the commit messages (or split into separate commits).
Also, can you link to upstream change logs in the commit messages (Changes:
field)? For X11 libs check https://lists.x.org/archives/xorg-announce/ Doing so helps post-push review (more eyes to check if anything was missed) and for users to know whether to update immediately.
f4c896e
to
809c3f0
Compare
Thank you for the review! I have addressed all the comments, please take a look. |
graphics/libepoxy/Makefile
Outdated
USE_GL= glesv2 egl | ||
USE_LDCONFIG= yes | ||
SHEBANG_FILES= src/gen_dispatch.py | ||
|
||
USE_GITHUB= yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's moved here?
https://download.gnome.org/sources/libepoxy/1.5/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use upstream release tarball over Github, see https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
@jbeich What should be done to get this in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not part of x11@, so my review doesn't count as maintainer approval.
fc616d1 should probably be squashed into b53cc99. Otherwise, Changes
in PORTREVISION-only commit makes no sense.
If you're going to update/rebase this PR while waiting for the maintainer maybe also include libwacom-2.12.2.
Changes: https://gitlab.freedesktop.org/xorg/lib/libsm/-/compare/libSM-1.2.3...libSM-1.2.4 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX, add TEST_TARGET Changes: https://gitlab.freedesktop.org/xorg/lib/libxau/-/compare/libXau-1.0.9...libXau-1.0.11 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX Changes: https://gitlab.freedesktop.org/xorg/lib/libxaw/-/compare/libXaw-1.0.14...libXaw-1.0.16 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX Changes: https://gitlab.freedesktop.org/xorg/lib/libxfixes/-/compare/libXfixes-6.0.0...libXfixes-6.0.1 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Changes: https://gitlab.freedesktop.org/xorg/lib/libxfont/-/compare/libXfont2-2.0.5...libXfont2-2.0.6 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX Changes: https://gitlab.freedesktop.org/xorg/lib/libxi/-/compare/libXi-1.8...libXi-1.8.1 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX Changes: https://gitlab.freedesktop.org/xorg/lib/libxinerama/-/compare/libXinerama-1.1.4...libXinerama-1.1.5 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX Changes: https://gitlab.freedesktop.org/xorg/lib/libxrandr/-/compare/libXrandr-1.5.2...libXrandr-1.5.4 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Changes: https://gitlab.freedesktop.org/xorg/lib/libxrender/-/compare/libXrender-0.9.10...libXrender-0.9.11 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX Changes: https://gitlab.freedesktop.org/xorg/lib/libxtst/-/compare/libXtst-1.2.3...libXtst-1.2.4 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Remove GNU_CONFIGURE_MANPREFIX Changes: https://gitlab.freedesktop.org/xorg/lib/libxxf86vm/-/compare/libXxf86vm-1.1.4...libXxf86vm-1.1.5 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Changes: https://gitlab.freedesktop.org/xorg/lib/libfs/-/compare/libFS-1.0.8...libFS-1.0.9 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
Changes: https://github.com/anholt/libepoxy/releases/tag/1.5.10 Reviewed by: diizzy, jbeich Tested by: arrowd Pull Request: #273 Sponsored by: Serenity Cybersecurity, LLC
I've gone ahead and pushed X libraries updates, as these are mostly trivial. I did not push evdev and wacom stuff, though. @Awoonyaa please rebase. |
Changes: https://github.com/linuxwacom/libwacom/releases/tag/libwacom-2.12.2 Sponsored by: Serenity Cybersecurity, LLC
Sponsored by: Serenity Cybersecurity, LLC
x11/libinput tools depends on py-libevdev rather than on py-evdev for some time. So py-libevdev part should be committed after x11@freebsd.org approval along with corresponding x11/libinput change. |
Please, take a look. Poudriere testport works with these ports.
@jbeich @evadot @arrowd