Refactor strchr(p, 0) -> p + strlen(p) #1022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are both equivalent. However, given that strchr actually in fact just special cases 0, it is better to just make the intention clearer anyway by conveying in the code itself that this is what is happening.
rilysh
reviewed
Jan 10, 2024
| while (--t >= buf && *t == '\\') | ||
| continuation = !continuation; | ||
| for (t = buf; *t && *t == '\\'; t++) | ||
| continuation ^= 1; |
There was a problem hiding this comment.
Why continuation ^= 1? This makes understanding the logic even harder. IMO the previous one is better here.
igalic
suggested changes
Jan 10, 2024
|
Since this doesn't solve an actual problem, make things demonstrably faster, etc. I'm going to close it. IT's too churny and only introduces risk of regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are both equivalent. However, given that strchr actually in fact just special cases 0, it is better to just make the intention clearer anyway by conveying in the code itself that this is what is happening.