-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find: Allow '/' to be used with -perm for GNU compatibility #1060
Conversation
I feel like this would require a documentation update |
f97f65b
to
74d7494
Compare
Fixed. |
Can you rebase to a newer main and do a To my eyeballs, though, this looks good. |
74d7494
to
d2bce6c
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one final request
looks fine otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file will need a .Dd
bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks!
Once the .Dd bump happens, I'll commit. It all looks good otherwise. |
d2bce6c
to
57b942f
Compare
Fixed. |
@bsdimp disguised as @qemu-bsd-user, maybe it is missing the |
I find I think In any case the code change LGTM (and thanks for improving GNU compatibility). |
Checking into things a bit more, POSIX.1 2001 (issue 6) and POSIX.1 2018 (issue 7) has the '+' sign listed, but not the '/' sign, so that's a gnu find extension. Gnu find evidentally deprecated + in favor of / in 2005. I've not checked to see if POSIX.1 202x has this or not. My not-completley-public standards archive is offline, so I can't check. |
In 2005, Gnu find deprecated '+' as the leading character for the -perm argument, instead preferring '/' with the same meaning. Implement that behavior here, and document it in the man page. Reviewed by: imp, emaste Pull Request: #1060
Merged. I hope it's OK, but I added a blurb in the STANDARDS section about this extension. |
In 2005, Gnu find deprecated '+' as the leading character for the -perm argument, instead preferring '/' with the same meaning. Implement that behavior here, and document it in the man page. Reviewed by: imp, emaste Pull Request: freebsd/freebsd-src#1060
Since 2005 GNU find(1) no longer allows '+' to be used with
-perm
, forcing the use of a/
instead.This PR adds support for this character as synonym for '+'.
Fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276326