Fix "%hhi" conversion for kvprintf() #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rilysh
approved these changes
Jun 13, 2024
bsdimp
approved these changes
Jun 28, 2024
|
We use this function in the RTEMS real-time operating system. I came across this issue while writing validation tests for it on an arm target. Here, "char" is still unsigned: |
Ah yes. I was sure that EABI had changed that.... In any event, I think the changes is good and will land it soon. |
bsdimp
approved these changes
Jun 28, 2024
The signedness of "char" is implementation-dependent. Reviewed by: imp,zlei,nightquick@proton.me Pull Request: freebsd#1290
bsdimp
force-pushed
the
fix-hhi-conversion-for-kvprintf
branch
from
d71ce25 to
fc3e533
Compare
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Oct 29, 2024
The signedness of "char" is implementation-dependent. Reviewed by: imp,zlei,nightquick@proton.me Pull Request: freebsd/freebsd-src#1290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signedness of "char" is implementation-dependent.