-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -M option to display Monday as the first day of the week in cal(1) #1294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only comment on the manual page. Would you be willing to tag SPDX?
.\"-
.\" SPDX-License-Identifier: BSD-2-Clause
.\"
This patch is a nice change for Germans who start weeks on Mondays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! After this, manual changes LGTM.
Co-authored is incorrect in this case. This work is entirely your own. The appropriate way to credit me is with a Please squash these down to one commit. The first word should describe what's being changed, then a colon, then a short description. Since this change shouldn't break anything, don't forget to specify Example:
|
It seems I've done this right )) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, you still have to find someone to review the src, but everything I'm qualified to comment on looks great.
Thanks for coming here and submitting. Two very minor style nits, but the rest looks great. |
I expect the builds to work... and the commit message looks good too. |
I tested it the other day, build worked on amd64/main. |
Is there another cal implementation that uses |
I looked briefly. I couldn't find one. Gcal was the only other cli program I found. It can also do Monday start, but that is tied to using isolated week mode... |
Debian/Ubuntu uses FreeBSD's patched OpenBSD and util-linux use |
Wow, are you guys seeing this? They took BSDL code, improved it, and didn't wrap it in GPL! Ian Murdock was a great man. |
Yea. But didn't keep up with upstream... It's good they kept the original license... A lot of early BSDL and BSDL-ish code was swallowed by the GPL either just because they felt like it, or because in a few cases, they located the original author and they said yes. I applaud this group for doing the right thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good now.
MFC after: 2 weeks Reviewed by: imp, Alexander Ziaee, Pull Request: #1294
MFC after: 2 weeks Reviewed by: imp, Alexander Ziaee, Pull Request: freebsd/freebsd-src#1294
As you can find, FreeBSD cal(1) man page says that
But daily it is more comfortable if weeks start from Monday.
I know that there is ncal (vertical) mode which always starts from Monday,
but any other calendar in the world (software or that on the wall) is horizontal,
so ncal is uncomfortable too.
So I've made a simple patch that adds -M option to cal(1) to start week from Monday.
Tried to make as minimal changes to original code as possible.