Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpa_cli.8: describe better + tag spdx + linter nit #1299

Closed
wants to merge 1 commit into from

Conversation

concussious
Copy link
Contributor

"how do I switch active wifi network on console"
"% apropos wifi"

MFC after: 3 days

@concussious concussious force-pushed the wpa_cli.8 branch 3 times, most recently from 69ee173 to 40f4765 Compare June 21, 2024 12:03
.Dt WPA_CLI 8
.Os
.Sh NAME
.Nm wpa_cli
.Nd "text-based frontend program for interacting with wpa_supplicant"
.Nd console utility for wifi authentication with wpa_supplicant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 'WiFi'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Wi-Fi" is the trademark. But people are likely searching for wifi, which is the whole reason to change it here.

So what do we do elsewhere?

Copy link
Contributor Author

@concussious concussious Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we abusing the trademark if we use it the way it's used in the real world?

I have a baseless suspicion no one has ever initially searched ms-dos or wi-fi.

Edit: I think the body of the doc should use the proper trademark for correctness, but the Document Description should not for visibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Wi-Fi" is the trademark. But people are likely searching for wifi, which is the whole reason to change it here.

So what do we do elsewhere?

The wifi(4) man page has the description: generic WiFi 802.11 link-layer support

"Wi-Fi" appears in the body of man pages such as networking(7).

apropos wi-fi yields no results. apropos wifi is case insensitive and will therefore include wpa_cli(8) regardless of how it is capitalized.

So, I suggest 'WiFi', but have no problem with 'wifi'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, let's use 'WiFi' but 'wifi' also works.
As for trademark issues: there's none. We're not selling products that claim to be in conformance, so we're under no obligation to use it correctly everywhere w/o exception. So I like having it wifi in the doc descrip, but Wi-Fi elsewhere. Might not be a bad thing to do a sweep on for existing man pages and handbook entries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy, doc sweep on tonight's todo.

"how do I switch active wifi network on console"
"% apropos wifi"

MFC after:	3 days
Reviewed by:	mhorne, imp
Pull Request:	freebsd#1299
mhorne pushed a commit to mhorne/freebsd that referenced this pull request Jun 27, 2024
"how do I switch active wifi network on console"
"% apropos wifi"

MFC after:	3 days
Reviewed by:	mhorne, imp
Pull Request:	freebsd#1299
@mhorne
Copy link
Contributor

mhorne commented Jun 27, 2024

Merged to main as 18a27dd. Please close.

@bsdimp bsdimp added the merged label Jun 27, 2024
@concussious
Copy link
Contributor Author

Thanks @mhorne!

freebsd-git pushed a commit that referenced this pull request Jul 4, 2024
"how do I switch active wifi network on console"
"% apropos wifi"

MFC after:	3 days
Reviewed by:	mhorne, imp
Pull Request:	#1299

(cherry picked from commit 18a27dd)
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Oct 29, 2024
"how do I switch active wifi network on console"
"% apropos wifi"

MFC after:	3 days
Reviewed by:	mhorne, imp
Pull Request:	freebsd/freebsd-src#1299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants