Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop forcing -g in mpi3mr module because it breaks non-debug install. #1314

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Stop forcing -g in mpi3mr module because it breaks non-debug install. #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814bf1f
virtio_p9fs: fix panic on qemu/kvm
daniloegea Jul 6, 2024
4c6cf05
Stop forcing -g in mpi3mr module because it breaks non-debug install.
Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sys/dev/virtio/p9fs/virtio_p9fs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,12 @@
mount_tag = malloc(mount_tag_len + 1, M_P9FS_MNTTAG,
M_WAITOK | M_ZERO);

virtio_read_device_config(dev,
virtio_read_device_config_array(dev,
offsetof(struct virtio_9pnet_config, mount_tag),
mount_tag, mount_tag_len);
mount_tag, 1, mount_tag_len);

device_printf(dev, "Mount tag: %s\n", mount_tag);

Check warning on line 360 in sys/dev/virtio/p9fs/virtio_p9fs.c

View workflow job for this annotation

GitHub Actions / Style Checker 

Missing Signed-off-by: line
mount_tag_len++;
chan->mount_tag_len = mount_tag_len;
chan->mount_tag = mount_tag;
Expand Down
1 change: 0 additions & 1 deletion sys/modules/mpi3mr/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
SRCS+= device_if.h bus_if.h pci_if.h

CFLAGS+= -I${SRCTOP}/sys/compat/linuxkpi/common/include
DEBUG_FLAGS= -g

.include <bsd.kmod.mk>

Check warning on line 12 in sys/modules/mpi3mr/Makefile

View workflow job for this annotation

GitHub Actions / Style Checker 

Missing Signed-off-by: line
CWARNFLAGS.mpi3mr_sas.c= ${NO_WUNNEEDED_INTERNAL_DECL}
CWARNFLAGS.mpi3mr_mapping.c= ${NO_WSOMETIMES_UNINITIALIZED}
Loading