-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvme: Add support for Autonomous Power State Transition #1444
base: main
Are you sure you want to change the base?
Conversation
Generally, I like this. I'm unsure of what we should do by default... |
This comment was marked as outdated.
This comment was marked as outdated.
This is a great feature. But for some reason, I think that we can implement it in user space - nvmecontrol(8) |
This comment was marked as outdated.
This comment was marked as outdated.
Though my approach to configuring APST closely resembles the Linux implementation, I agree that its design could be improved. In particular, I totally agree with @wigneddoom on moving as much functionality as possible out of kernel, though I'm still considering the best way to achieve this. I've marked this PR as a draft, so I can take some time to give it more thought. Please remove the needs-review label for now. |
This comment was marked as outdated.
This comment was marked as outdated.
45d3802
to
913a3f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Enable use of already existing parameters, necessary for some features such as APST. Signed-off-by: Alexey Sukhoguzov <sap@eseipi.net>
APST is an optional NVMe power-saving feature that allows devices to autonomously enter higher non-operational power states after a certain amount of idle time, reducing the controller's overall power consumption. Signed-off-by: Alexey Sukhoguzov <sap@eseipi.net>
The apst_data tunable allows APST configuration to be adjusted during controller initialization. It accepts an array of encoded integers, each defining specific transition parameters. Signed-off-by: Alexey Sukhoguzov <sap@eseipi.net>
I've created a revision (D47381) for |
APST is an optional NVMe power-saving feature that allows devices to autonomously enter higher non-operational power states after a certain amount of idle time, reducing the controller's overall power consumption.