Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppp.8: Fix typo cuad0 -> cuau0 #1515

Merged
merged 1 commit into from
Nov 19, 2024
Merged

ppp.8: Fix typo cuad0 -> cuau0 #1515

merged 1 commit into from
Nov 19, 2024
+28 −19

Conversation

jlduran
Copy link
Member

@jlduran jlduran commented Nov 5, 2024

Move PR #248359 here as part of a cleanup of personal old bug reports.

concussious
concussious reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@concussious concussious left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical catch!

Removing redundant normal text macros is ok with me. There are a few more syntax errors on this page, but none user facing, except:

The linter complains about line 266 being too long, which is a seemingly dead link. Are you seeing that too?

usr.sbin/ppp/ppp.8 Outdated Show resolved Hide resolved
bsdimp
bsdimp reviewed Nov 5, 2024
View reviewed changes
usr.sbin/ppp/ppp.8 Outdated Show resolved Hide resolved
@jlduran
Copy link
Member Author

jlduran commented Nov 5, 2024

The linter complains about line 266 being too long, which is a seemingly dead link. Are you seeing that too?

Ah yes, I guess the file is now at:
https://winprotocoldocs-bhdugrdyduf5h2e4.b02.azurefd.net/MS-CBCP/%5bMS-CBCP%5d.pdf

I would just:

.Pq https://winprotocoldocs-bhdugrdyduf5h2e4.b02.azurefd.net/MS-CBCP/%5bMS-CBCP%5d.pdf .

@concussious
Copy link
Contributor

concussious commented Nov 5, 2024 •
edited
Loading

The linter complains about line 266 being too long, which is a seemingly dead link. Are you seeing that too?

Ah yes, I guess the file is now at: https://winprotocoldocs-bhdugrdyduf5h2e4.b02.azurefd.net/MS-CBCP/%5bMS-CBCP%5d.pdf

I would just:

.Pq https://winprotocoldocs-bhdugrdyduf5h2e4.b02.azurefd.net/MS-CBCP/%5bMS-CBCP%5d.pdf .

Nice find! If you want to Pq, please also use Lk so that the link is clickable.

Edit: although, this should really go in the see also section, but I do not object to fixing it in place.

@jlduran
Copy link
Member Author

jlduran commented Nov 5, 2024

Edit: although, this should really go in the see also section, but I do not object to fixing it in place.

Yes, my main objective is to silence the linter before applying the actual fix, not to thoroughly clean up the manual.
But I do plan on doing some clean up for other man pages in the near future™.

mhorne
mhorne approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@mhorne mhorne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead with this.

@jlduran
ppp.8: Fix typo cuad0 -> cuau0
21ca690 
Fix a typo that was missed probably because it was capitalized.
Mark up with .Pa and fix capitalization.

Specify that cuaUX and cuauX are for USB and UART attachments
respectively.

- Silence most lint warnings
- Update outdated links
- Minor style fixes
- Some igor(1) warnings were ignored on purpose

PR:		248359
Reviewed by:	imp, mhorne, Alexander Ziaee <concussious.bugzilla@runbox.com>
Approved by:	emaste (mentor)
Fixes:	839f11a ("A number of places in the source tree still reference cuad.* after sio(4) was deprecated by uart(4).")
MFC after:	1 week
Pull Request:	freebsd#1515
@freebsd-git freebsd-git merged commit 21ca690 into freebsd:main Nov 19, 2024
7 of 9 checks passed
@jlduran jlduran deleted the fix-ppp-typo-cuau0 branch November 19, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsdimp bsdimp bsdimp left review comments

@concussious concussious concussious approved these changes

@mhorne mhorne mhorne approved these changes

Assignees
No one assigned
Labels
man-only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlduran @concussious @bsdimp @mhorne @freebsd-git