Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap_fileargs.3: Comprehensive rewrite for improved clarity and accuracy #1551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kfv
Copy link
Contributor

@kfv kfv commented Dec 14, 2024

Extensively revised the manual page with clearer phrasing, better structure, and corrected grammar throughout. Also fixed multiple typos and improved overall readability of the documentation.

@kfv
Copy link
Contributor Author

kfv commented Dec 14, 2024

Cc: @oshogbo

@oshogbo oshogbo self-assigned this Dec 14, 2024
Copy link
Contributor

@concussious concussious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Few suggestions:

lib/libcasper/services/cap_fileargs/cap_fileargs.3 Outdated Show resolved Hide resolved
lib/libcasper/services/cap_fileargs/cap_fileargs.3 Outdated Show resolved Hide resolved
lib/libcasper/services/cap_fileargs/cap_fileargs.3 Outdated Show resolved Hide resolved
lib/libcasper/services/cap_fileargs/cap_fileargs.3 Outdated Show resolved Hide resolved
@kfv kfv force-pushed the kfv/docs/cap_fileargs.3 branch 2 times, most recently from a3caefb to 2dae25d Compare December 15, 2024 09:58
@kfv kfv requested a review from concussious December 15, 2024 09:58
@concussious
Copy link
Contributor

I don't think this was the commit you intended to push?

@kfv
Copy link
Contributor Author

kfv commented Dec 15, 2024

How come?

@kfv
Copy link
Contributor Author

kfv commented Dec 15, 2024

By the way, I’m sorry if I forgot to thank you. It’s been a tough day, and I can’t even remember how I managed to handle the changes you requested.

@concussious
Copy link
Contributor

How come?

The commits appear to be unchanged.

By the way, I’m sorry if I forgot to thank you.

Hey, likewise. Improvements to the manual excite me.

@kfv
Copy link
Contributor Author

kfv commented Dec 17, 2024

Whoops! I'll take a look in an hour. I might have missed something.

Extensively revised the manual page with clearer phrasing, better structure,
and corrected grammar throughout. Also fixed multiple typos and improved
overall readability of the documentation.

Signed-off-by: Faraz Vahedi <kfv@kfv.io>
@kfv kfv force-pushed the kfv/docs/cap_fileargs.3 branch from 2dae25d to 9f5a2c5 Compare December 17, 2024 10:58
@kfv
Copy link
Contributor Author

kfv commented Dec 17, 2024

You were right, mate. Requested changes are now pushed. Please take a look and let me know if anything else is necessary to consider and apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants