Skip to content

dot.shrc: words to words, should be singular #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

grahamperrin
Copy link
Contributor

Jump from one word to another. Not words to words.

Jump from one word to another. Not words to words.
Jump from one word to another. Not words to words.
@grahamperrin grahamperrin marked this pull request as ready for review January 3, 2025 21:08
@grahamperrin
Copy link
Contributor Author

Suggested reviewer: @bapt (the original author). 2021:

@concussious
Copy link
Contributor

These files have been and will be many people's first impressions of configuration files. We should carefully consider the style of everything in this directory and make it consistent.

@bsdimp
Copy link
Member

bsdimp commented Apr 28, 2025

While I agree we should be more thorough, this is a good improvement, so I'll land it.
When someone else comes along with more wide-ranging changes, we can evaluate those then.

@bsdimp bsdimp added the merged Closed commit that's been merged label Apr 28, 2025
@bsdimp
Copy link
Member

bsdimp commented Apr 28, 2025

ghpr helper script closed this after push to source of truth.

@bsdimp bsdimp closed this Apr 28, 2025
freebsd-git pushed a commit that referenced this pull request Apr 28, 2025
Jump from one word to another. Not words to words.

Reviewed by: imp
Pull Request: #1565
@grahamperrin grahamperrin deleted the patch-6 branch April 29, 2025 01:58
@grahamperrin
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Closed commit that's been merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants