traceroute/traceroute6: Cleanup usage and manual fixes #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Given the differences between our code in |
|
Note to self: Cross-builds are failing for aarch64-clang-12 after 9eecef0, due to clang-12 being too old? |
bsdimp
reviewed
Dec 26, 2023
bsdimp
reviewed
Dec 26, 2023
bsdimp
reviewed
Dec 26, 2023
bsdimp
reviewed
Dec 26, 2023
bsdimp
reviewed
Dec 26, 2023
|
So this generally looks good, but the manual page could use a little attention as noted wrt line breaks. If you are really ambitious, you could re-wrap the lines now broken (the join comments I made is a minimal subset of this). Otherwise, I like it. You now have your commit bit and if you do the above, you can mark this as 'Reviewed-by: imp' when you commit it :) |
|
Will do! |
jlduran
force-pushed
the
fix-traceroute-packlen
branch
from
009efd4 to
d5791f0
Compare
jlduran
added a commit
to jlduran/freebsd-src
that referenced
this pull request
Dec 27, 2023
Silence the warning: argument to 'sizeof' in 'strncpy' call is the same expression as the source; did you mean to use the size of the destination?" by using strlcpy() and the size of the destination (device). No functional change intended. Reviewed by: imp Pull Request: freebsd#901
jlduran
added a commit
to jlduran/freebsd-src
that referenced
this pull request
Dec 27, 2023
Standardize the documentation and update it to reflect the current values. Reviewed by: imp Pull Request: freebsd#901
jlduran
added a commit
to jlduran/freebsd-src
that referenced
this pull request
Dec 27, 2023
Reviewed by: imp Pull Request: freebsd#901
jlduran
added a commit
to jlduran/freebsd-src
that referenced
this pull request
Dec 27, 2023
Reviewed by: imp Pull Request: freebsd#901
jlduran
added a commit
to jlduran/freebsd-src
that referenced
this pull request
Dec 27, 2023
Reviewed by: imp Pull Request: freebsd#901
|
The man pages were originally wrapped at 72 CPL. Old school! Felt a little sad extending it to 80 chars. |
Silence the warning: argument to 'sizeof' in 'strncpy' call is the same expression as the source; did you mean to use the size of the destination?" by using strlcpy() and the size of the destination (device). No functional change intended.
Standardize the documentation and update it to reflect the current values.
jlduran
force-pushed
the
fix-traceroute-packlen
branch
from
d5791f0 to
d931b81
Compare
|
looks good now, minor tweaks to one or two of the commit messagesg. |
freebsd-git
pushed a commit
that referenced
this pull request
Feb 3, 2024
Silence the warning: argument to 'sizeof' in 'strncpy' call is the same expression as the source; did you mean to use the size of the destination?" by using strlcpy() and the size of the destination (device). No functional change intended. Reviewed by: imp Pull Request: #901
freebsd-git
pushed a commit
that referenced
this pull request
Feb 3, 2024
Standardize the documentation and update it to reflect the current values. Reviewed by: imp Pull Request: #901
freebsd-git
pushed a commit
that referenced
this pull request
Feb 3, 2024
Reviewed by: imp Pull Request: #901
freebsd-git
pushed a commit
that referenced
this pull request
Feb 3, 2024
Fix a number of warning mandoc -Tlint and igor turned up. No changes intended. Reviewed by: imp Pull Request: #901
freebsd-git
pushed a commit
that referenced
this pull request
Feb 3, 2024
Reviewed by: imp Pull Request: #901
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 1, 2024
Silence the warning: argument to 'sizeof' in 'strncpy' call is the same expression as the source; did you mean to use the size of the destination?" by using strlcpy() and the size of the destination (device). No functional change intended. Reviewed by: imp Pull Request: freebsd/freebsd-src#901
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 1, 2024
Standardize the documentation and update it to reflect the current values. Reviewed by: imp Pull Request: freebsd/freebsd-src#901
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 1, 2024
Reviewed by: imp Pull Request: freebsd/freebsd-src#901
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 1, 2024
Fix a number of warning mandoc -Tlint and igor turned up. No changes intended. Reviewed by: imp Pull Request: freebsd/freebsd-src#901
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 1, 2024
Reviewed by: imp Pull Request: freebsd/freebsd-src#901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following are a series of minor fixes, intended to reduce the differences between the two utilities, in the event of a possible future unification.