Implement ALL target for snapshot, snaplist and snapremove #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defenso-QTH
force-pushed
the
snapall-PR
branch
from
d0761a1 to
924a133
Compare
Defenso-QTH
changed the title
Pull Request Test Coverage Report for Build 10965406135Details
💛 - Coveralls |
Defenso-QTH
force-pushed
the
snapall-PR
branch
from
924a133 to
1997670
Compare
vbarbaresi
reviewed
Sep 20, 2024
Use isinstance() instead of type() Co-authored-by: Vincent Barbaresi <vincent.barbaresi@datadoghq.com>
2 tasks
|
Thank you @Defenso-QTH and @vbarbaresi for review ! |
dgeo
pushed a commit
to criecm/iocage
that referenced
this pull request
Nov 29, 2024
* Implement ALL target for snapshot, snaplist and snapremove * Apply suggestions from code review Use isinstance() instead of type() Co-authored-by: Vincent Barbaresi <vincent.barbaresi@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Okay so this is a proposal to close #18.
It brings:
iocage snaplist ALLto list snapshots from all jails at onceiocage snapshot ALL -n <name>to take a snapshot of all jails at once, with a common name. Intended for mass backup, upgrade or migration scenarios.iocage snapremove ALL -n <name>to remove such a common snapshot from all jails.iocage snapremove <jail> -n ALL -fto remove all snapshots from a jail. It requires-for--force.iocage snapremove ALL -n ALL -fto remove all snapshots from all jails.I provided some tests for all these features and an update for the documentation.
Make sure to follow and check these boxes before submitting a PR! Thank you.