Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kyua is too strict about TAP SKIP commands #159

Closed
brooksdavis opened this issue Jun 29, 2016 · 1 comment
Closed

kyua is too strict about TAP SKIP commands #159

brooksdavis opened this issue Jun 29, 2016 · 1 comment
Labels

Comments

@brooksdavis
Copy link
Contributor

The TAP specification (http://testanything.org/tap-specification.html) states any comment in the output that begins with "skip" is a SKIP command and explicitly includes this example:

1..0 # Skipped: WWW::Mechanize not installed

FreeBSD's usr.bin/sed/tests/inplace_race_test.sh produces such a line when running on a non-SMP system, but kyua rejects it with:

inplace_race_test:main  ->  broken: Test plan is reversed  [0.502s]

Changing "Skipped:" to "SKIP" causes the test to be skipped properly.

inplace_race_test:main  ->  skipped: : not an SMP system  [0.489s]

A few other tests suggest it is looking for an upper case skip. For example, making the line start with SKIPPED: yields:

inplace_race_test:main  ->  skipped: PED: not an SMP system  [0.509s]
brooksdavis added a commit to CTSRD-CHERI/cheribsd that referenced this issue Jun 30, 2016
@jmmv jmmv closed this as completed in 910aba0 Jul 3, 2016
@jmmv
Copy link
Member

jmmv commented Jul 3, 2016

Grr, that TAP "specification" is so poorly specified that it doesn't deserve the name. The mention that directives are case insensitive is buried in a random place in the document, and the fact that "Skipped:" is a valid directive only appears in a sample line and is not explained anywhere. May this be a mistake on their side?

Anyway, changed the parser to accept these and other cases. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants