Finish 'hash' mode for pkg create #1829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanjude
force-pushed
the
hashed_pkgs
branch
2 times, most recently
from
e9f71ff to
44c7469
Compare
|
Updated to require much less diff than before |
Add two new configuration knobs to control creating packages with the short hash appended to the package name. PKG_CREATE_HASH renames the packages to use the short hash PKG_CREATE_SYMLINK creates a symlink from the original pkg filename This builds upon b9f1e05 and adds the missing documentation Also: pkg create should write to .pkgname first then rename on success This allows the ports tree to have pkg create output directly to the destination directory, instead of copying the file afterwards The hash is separated from the version by a ~ since this character is not already used as part of a version numbers. Many places in the code assume the version is everything after the last - character. Update the fetch code to also use ~ to separate the hash in its cache
|
This is superceeded by master...allanjude:hashed_repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new configuration knobs to control creating packages with
the short hash appended to the package name.
PKG_CREATE_HASH renames the packages to use the short hash
PKG_CREATE_SYMLINK creates a symlink from the original pkg filename
This builds upon b9f1e05 and adds
the missing documentation
Also:
pkg create should write to .pkgname first then rename on success
This allows the ports tree to have pkg create output directly to the
destination directory, instead of copying the file afterwards
The hash is separated from the version by a ~ since this character
is not already used as part of a version numbers. Many places in the
code assume the version is everything after the last - character.