Cleanup harness generation and add missing vl_finish(). #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this solves the mystery of why some versions of verilator appear to fail with a:
The harness generated by
chisel3/src/main/resources/chisel3/top.cpp
contains a definition ofvl_finish()
while the harness generated bychisel-testers/src/main/scala/chisel3/iotesters/VerilatorBackend.scala
doesn't.Tests run with pure Chisel3 and FIRRTL will pass without problems, while tests using chisel-testers will fail at the link stage.
This PR converts multiple
codeBuffer.append()
s with individual C++ source lines into twocodeBuffer.append()
s with triple quotes and adds the missingvl_finish()
definition.