Fix RerunWithoutElaboration #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chick
commented
Apr 9, 2019
chick
commented
- I believe this test was re-activated in broken form
- Happened when fixed the verilator check method
- Made this into a single test to ensure sequential execution
- Moved the working directory for test into test_run_dir
- I believe this test was re-activated in broken form - Happened when fixed the verilator check method - Made this into a single test to ensure sequential execution - Moved the working directory for test into test_run_dir
ucbjrl
approved these changes
Apr 9, 2019
| @@ -14,13 +14,12 @@ class RerunWithoutElaboratonAndCompileSpec extends FreeSpec with Matchers { | |||
| "Demonstrate how to re-run a given test without recompiling" - { | |||
| "build once" in { | |||
| iotesters.Driver.execute( | |||
| Array("--backend-name", "verilator", "--target-dir", "build1", "--top-name", "PlusOne"), () => new PlusOne | |||
| Array("--backend-name", "verilator", "--target-dir", "test_run_dir/build1", "--top-name", "PlusOne"), () => new PlusOne | |||
There was a problem hiding this comment.
Could we make this path (and the one following at line 22) more DRYer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.