Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bad html characters from appearing in printf port names #26

Merged
merged 1 commit into from
Oct 1, 2019
Merged

fixed bad html characters from appearing in printf port names #26

merged 1 commit into from
Oct 1, 2019

Conversation

chick
Copy link
Contributor

@chick chick commented Sep 30, 2019

  • use a simple number as cell reference for printf port name
  • escape to html parens and angle brackets in port display names

@chick
fixed bad html characters from appearing in printf port names
1ab49bc 
- use a simple number as cell reference for printf port name
- escape to html parens and angle brackets in port display names
@chick chick added the bug Something isn't working label Sep 30, 2019
@chick chick requested a review from ucbjrl September 30, 2019 23:57
@chick chick self-assigned this Sep 30, 2019
@chick chick mentioned this pull request Sep 30, 2019
Open
ucbjrl
ucbjrl approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@ucbjrl ucbjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chick chick merged commit 7a25721 into master Oct 1, 2019
@ucbjrl ucbjrl added this to the 1.1.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucbjrl ucbjrl ucbjrl approved these changes

Assignees

@chick chick

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chick @ucbjrl