refactor ReplaceFrom() #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR, i will take a deeper look soon. |
sibuk-harabudjasim
force-pushed
the
master
branch
from
45c5362 to
2770fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #100, prepared PR with refactor of
ReplaceFrom()to enclose all changes in single BeginEdit-EndEdit frame to be able to enclose it with transaction.Had to do small enhancements to
reflect.goto be able to reuse existingTestReplaceFrom()test. Reflect-based Node did not tolerate request flags.Also, please pay attention to changed payload structure in test, please ensure that such change is not breaking any existing contracts. I found several usecases where payload structure is not compatible with RESTCONF rfc8040 spec. I'll try to fix that in future PRs.
And finally, list cleanup code might be not optimal, but it is baseline for optimizations. Please, give feedback if you see a easy way to improve that.
Hope this PR is good enough for this project. I've put a lot of effort to understand this edit strategy but still intuition is a big part of this PR :)