Skip to content

Commit

Permalink
Use PySide6 in our dev environments
Browse files Browse the repository at this point in the history
Drop PySide2 from our dependencies (previously used only on Linux
environments) and use PySide6 in all dev environments. The reason is
that PySide2 (from PyPI) does not support Python 3.11, and the variants
that do (Fedora/Debian packages) need to backport fixes from PySide6.

Our original attempt was to build PySide2 wheels for Python 3.11 but
it was not simple, nor maintainable. So, we were left with two options:

1. Install Python 3.10 in dev environments that have Python 3.11 by
   default.
2. Use PySide6 in all of our environments.

In both cases, we break package parity with the user's system, since we
are not testing Dangerzone under the same conditions. However, since
option (2) is forwards-compatible with where we want to move the
project (use Qt6 and PySide6), we chose that one.

Fixes #330
  • Loading branch information
apyrgio committed Feb 7, 2023
1 parent aa53739 commit 8b5b957
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 40 deletions.
39 changes: 2 additions & 37 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ authors = ["Micah Lee <micah.lee@theintercept.com>"]
license = "MIT"

[tool.poetry.dependencies]
python = ">=3.7,<3.11"
python = ">=3.7,<3.12"
click = "*"
appdirs = "*"
PySide2 = {version = "5.15.2.1", platform = "linux"}
PySide6 = {version = "^6.4.1", markers = "sys_platform == 'win32' or sys_platform == 'darwin'"}
PySide6 = "^6.4.1"
colorama = "*"
pyxdg = {version = "*", platform = "linux"}

Expand Down

0 comments on commit 8b5b957

Please sign in to comment.