Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

help text for dangerzone-container should not hardcode docker #122

Closed
pymnh opened this issue Jul 21, 2021 · 0 comments
Closed

help text for dangerzone-container should not hardcode docker #122

pymnh opened this issue Jul 21, 2021 · 0 comments

Comments

@pymnh
Copy link
Contributor

pymnh commented Jul 21, 2021 •
edited
Loading

dangerzone-container runs either podman or docker depending on the platform but is hardcoded to print docker commands as help message, like here.

I'd happily do a PR but will need to (re)familiarize myself with python and click 😅
gmarmstrong added a commit to gmarmstrong/dangerzone that referenced this issue Jun 8, 2022
@gmarmstrong
Don't hardcode "Docker" in help text
ce95dff 
Fixes freedomofpress#122
@gmarmstrong gmarmstrong mentioned this issue Jun 15, 2022
Closed
deeplow added a commit that referenced this issue Sep 15, 2022
@deeplow
remove hardcoded 'docker' logging reference
33e4672 
Closes #122 as this was the last remaining hardcoded docker
reference where the code also applied to podman.
@apyrgio apyrgio mentioned this issue Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type hints and refactor most *Common methods to be static or functional gmarmstrong/dangerzone
1 participant
@pymnh