Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong container runtime detection on Linux #212

Closed
apyrgio opened this issue Sep 22, 2022 · 0 comments · Fixed by #906
Closed

Wrong container runtime detection on Linux #212

apyrgio opened this issue Sep 22, 2022 · 0 comments · Fixed by #906
Assignees
@almet
Labels
bug Something isn't working good first issue Good for newcomers P:linux
Milestone
0.8.0

Comments

@apyrgio
Copy link
Contributor

apyrgio commented Sep 22, 2022

Description

Running Dangerzone on a Linux environment that does not have Podman properly configured, throws an error about Docker not running:

Dangerzone Requires Docker Desktop

Docker is installed but isn't running.

Open Docker and make sure it's running in the background.

This is unexpected because the newest Dangerzone release uses Podman instead of Docker.

Steps to Reproduce

OS: Ubuntu 22.04 (containerized via Docker)
Release: 0.3.2

  • Create an Ubuntu container with no special privileges, but with X11 access.
  • Install Dangerzone in it.
  • Make sure that podman images ls fails.
  • Run dangerzone within that container.
  • See the wrong error message in the GUI.

Expected Behavior

Inform the user that Podman is not properly configured. Ideally, explain what is the command that failed, either in the UI or in the logs.
@apyrgio apyrgio added bug Something isn't working good first issue Good for newcomers P:linux labels Sep 22, 2022
@apyrgio apyrgio self-assigned this Sep 22, 2022
@apyrgio apyrgio changed the title Wrong contrainer runtime detection on Linux Wrong container runtime detection on Linux Sep 22, 2022
@apyrgio apyrgio mentioned this issue Jul 25, 2024
Closed
@apyrgio apyrgio added this to the 0.8.0 milestone Aug 20, 2024
@almet almet mentioned this issue Aug 30, 2024
Merged
almet added a commit that referenced this issue Sep 11, 2024
@almet
Fix wrong container-runtime detection on Linux
18205ab 
Use "podman" when on Linux, and "docker" otherwise.

This commit also adds a text widget to the interface, showing the actual
content fo the error that happened, to help debug further if needed.

Fixes #212
@almet almet assigned almet and unassigned apyrgio Sep 12, 2024
almet added a commit that referenced this issue Sep 17, 2024
@almet
Fix wrong container-runtime detection on Linux
bb8bd17 
Use "podman" when on Linux, and "docker" otherwise.

This commit also adds a text widget to the interface, showing the actual
content fo the error that happened, to help debug further if needed.

Fixes #212
almet added a commit that referenced this issue Sep 17, 2024
@almet
Fix wrong container-runtime detection on Linux
933bd7f 
Use "podman" when on Linux, and "docker" otherwise.

This commit also adds a text widget to the interface, showing the actual
content fo the error that happened, to help debug further if needed.

Fixes #212
@almet almet closed this as completed in c3c7fbb Sep 18, 2024
apyrgio pushed a commit that referenced this issue Sep 27, 2024
@almet @apyrgio
Fix wrong container-runtime detection on Linux
2bdd563 
Use "podman" when on Linux, and "docker" otherwise.

This commit also adds a text widget to the interface, showing the actual
content fo the error that happened, to help debug further if needed.

Fixes #212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almet almet

Labels
bug Something isn't working good first issue Good for newcomers P:linux
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Fix wrong container runtime detection on Linux freedomofpress/dangerzone
2 participants
@almet @apyrgio