Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume container output when not parsed #316

Closed
deeplow opened this issue Jan 24, 2023 · 2 comments
Closed

Consume container output when not parsed #316

deeplow opened this issue Jan 24, 2023 · 2 comments
Assignees
@deeplow
Milestone
0.4.1

Comments

@deeplow
Copy link
Contributor

deeplow commented Jan 24, 2023

In #305 (specifically these lines), left space for some of the ran commands output to be printed and interpreted as JSON output from the container.

Example: the following output is the result of a libreoffice conversion process printing the line convert /tmp/input_file -> /tmp/input_file.pdf using filter : impress_pdf_Export

[INFO ] [doc FxtXm4] 0% Converting to PDF using LibreOffice
[ERROR] Invalid JSON returned from container:

	 convert /tmp/input_file -> /tmp/input_file.pdf using filter : impress_pdf_Export

[INFO ] [doc FxtXm4] 3% Calculating number of pages
@deeplow deeplow added this to the 0.4.1 milestone Jan 24, 2023
deeplow added a commit that referenced this issue Jan 27, 2023
@deeplow
Consume container output when it's not parsed
3ad27d4 
Revert run_command() logic to sending again stdout and stderr to
/dev/null (just as it was prior to commit d28aa5a). Fixes #316
@deeplow
Copy link
Contributor Author

deeplow commented Jan 27, 2023

In the future, we'll want to be able to see these outputs in a development environment and possibly compare then with the expected ones. That will be tracked with #319

@deeplow deeplow mentioned this issue Jan 27, 2023
Closed
deeplow added a commit that referenced this issue Jan 27, 2023
@deeplow
Consume container output when it's not parsed
db600c2 
Revert run_command() logic to sending again stdout and stderr to
/dev/null (just as it was prior to commit d28aa5a). Fixes #316
deeplow added a commit that referenced this issue Jan 27, 2023
@deeplow
Consume container output when it's not parsed
bb6ee5d 
Revert run_command() logic to sending again stdout and stderr to
/dev/null (just as it was prior to commit d28aa5a). Fixes #316
@deeplow deeplow self-assigned this Jan 30, 2023
@apyrgio
Copy link
Contributor

apyrgio commented Feb 7, 2023

Closed by #328.

@apyrgio apyrgio closed this as completed Feb 7, 2023
deeplow added a commit that referenced this issue Feb 21, 2023
@deeplow
Log container output in dev mode
042ad3f 
Additionally save a file with the container output next to the
original file `[original].pdf.container_log`.

This is needed in order to increase visibility of non-critical
errors/warnings. Previously some issues went undetected because
if this [1].

[1]: #316
deeplow added a commit that referenced this issue Feb 21, 2023
@deeplow
Log container output in dev mode
a3128d9 
Additionally save a file with the container output next to the
original file `[original].pdf.container_log`.

This is needed in order to increase visibility of non-critical
errors/warnings. Previously some issues went undetected because
if this [1].

[1]: #316
deeplow added a commit that referenced this issue Feb 21, 2023
@deeplow
Log container output in dev mode
c0bd1ee 
Additionally save a file with the container output next to the
original file `[original].pdf.container_log`.

This is needed in order to increase visibility of non-critical
errors/warnings. Previously some issues went undetected because
if this [1].

[1]: #316
deeplow added a commit that referenced this issue Feb 22, 2023
@deeplow
Log container output in dev mode
134dc27 
Additionally save a file with the container output next to the
original file `[original].pdf.container_log`.

This is needed in order to increase visibility of non-critical
errors/warnings. Previously some issues went undetected because
if this [1].

[1]: #316
deeplow added a commit that referenced this issue Mar 2, 2023
@deeplow
Log container output in dev mode
2961e8a 
Additionally save a file with the container output next to the
original file `[original].pdf.container_log`.

This is needed in order to increase visibility of non-critical
errors/warnings. Previously some issues went undetected because
if this [1].

[1]: #316
@deeplow deeplow mentioned this issue Mar 8, 2023
Merged
deeplow added a commit that referenced this issue Apr 6, 2023
@deeplow
Log container output in dev mode
ec145a4 
Additionally save a file with the container output next to the
original file `[original].pdf.container_log`.

This is needed in order to increase visibility of non-critical
errors/warnings. Previously some issues went undetected because
if this [1].

Optionally, this output can be saved into a file
`<original_file>.container_log`, if the environment variable
DZ_LOG_CONTAINER is set. The last line is the success status of the doc.
Note: this file will be appended and not overwritten.

[1]: #316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeplow deeplow

Labels
None yet
Projects
None yet
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

Consume container output when it's not parsed freedomofpress/dangerzone
2 participants
@apyrgio @deeplow