Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Container Dependencies #305

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Reduce Container Dependencies #305

merged 4 commits into from
Jan 23, 2023

Commits on Jan 23, 2023

  1. Remove PDFtk dependency (replace w/ pdftoppm) 

    PDFtk actually isn't needed. It was being used for breaking a PDF
into pages but this is something that be replaced by the already present
'pdftoppm'. Furthermore, by removing this dependency we contribute to
reproducible builds and overall supply chain security because it was
obtained from gitlab with no signature verification or version pinning.

The replacement 'pdftoppm' enabled us to do a shortcut:
 - before: PDF -> PDF pages -> PNG images -> RGB images
 - after:  PDF -> PPM images -> RGB images

And this last conversion step is trivial since the RGB format we were
using is just a PPM file without the metadata in its header.
    @deeplow
    deeplow committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d28aa5a View commit details
    Browse the repository at this point in the history

  2. Make pdf to ppm conversion dependent on num pages

    @deeplow
    deeplow committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    272d25a View commit details
    Browse the repository at this point in the history

  3. Remove openjdk-8 as a dependency. 

    default-jre and java dependencies dependencies had been added initially
[1] because of libreoffice-java-common, which is no longer present.
Then, when the image was changed from ubuntu to alpine [2], default-jre
was replaced with openjdk-8.

If java is still a dependency for libreoffice, then it should be pulled
automatically.

[1] firstlookmedia/dangerzone-converter@9ecdb9e
[2] firstlookmedia/dangerzone-converter@650ae6e
    @deeplow
    deeplow committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d7be28e View commit details
    Browse the repository at this point in the history

  4. Remove sudo: no longer needed 

    Fixes #232
    @deeplow
    deeplow committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    2da9732 View commit details
    Browse the repository at this point in the history