Update Poetry lock #377
Merged
Update Poetry lock #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `poetry lock` and allow updating the existing dependencies. This fixes a CI regression that was introduced by Poetry 1.4.1, which added stricter Python wheels validation Fixes #376
Due to a bump in our Python dependencies, we now install Black 23 instead of 22, which detects some of our files as badly formatted.
Due to a bump in our Python dependencies, we now install Mypy 1.1.1 instead of 0.982. This change triggered the following errors: * Incompatible default for argument <a> (default has type None, argument has type <t>): Mypy further explains here that PEP 484 prohibits implicit Optional, so we need to make these types explicit Optional. * Unused "type: ignore" comment, use narrower [method-assign] instead of [assignment]: Mypy has specialized some of its lints, meaning that we should switch to the newer variants. Also, it detected several other small inconsistencies. We fix all of these errors in this commit.
apyrgio
added a commit
that referenced
this pull request
Mar 27, 2023
Remove the association between MIME types and export filters, because LibreOffice is able to auto-detect them on its own. Instead, ask LibreOffice to simply convert the document to a .pdf. This association was cumbersome for yet another reason; there are MIME types that may be associated with more than one file type. That's why it's better to let LibreOffice decide the proper filter for the conversion. Our current understanding is that this change won't widen our attack surface for the following reasons: * The output filters for PDF documents are pretty specific, and we don't affect the input filters somehow. * The default behavior of LibreOffice on Alpine Linux is to disable macros. * We preemptively run LibreOffice in safe mode, to remove hardware acceleration and make sure that macros are not invoked as well. Closes #377
deeplow
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the Poetry lock file, to fix an issue with Poetry 1.4.1 and the Python wheels for Black 22. Also, fix some newly detected lint errors in the meantime.
Fixes #376