build-image.sh: Support building the image on Docker. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. The issue is that for linux releases we want to rely on podman. Installing docker is rather painful and we're relying on an external repository. So a while ago we moved away from And as I understand your gvisor PR is based on the assumption that Docker would be available on Linux, which may become a problem. Anyways, this is something that we can discuss with @apyrgio, but I don't think we'll move away from podman on linux (sadly for this and the other PR). |
|
Alright, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
install/linux/build-image.shscript to work with eitherpodmanordockerinstalled.(It also enables some more bash features to make shell scripts less error-prone.)