Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Explicitly use Ubuntu 24.04 for our runner images #958

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Oct 17, 2024

GitHub actions somehow managed to downgrade our runners from Ubuntu 24.04 to Ubuntu 22.04, even though we use ubuntu-latest. Make the Ubuntu 24.04 requirement more explicit, until GitHub migrates fully to this version for the ubuntu-latest tag.

Fixes #957

GitHub actions somehow managed to downgrade our runners from Ubuntu
24.04 to Ubuntu 22.04, even though we use `ubuntu-latest`. Make the
Ubuntu 24.04 requirement more explicit, until GitHub migrates fully to
this version for the `ubuntu-latest` tag.

Fixes #957
@almet
Copy link
Contributor

almet commented Oct 17, 2024

The problem seem to already have been reported upstream (actions/runner-images#10796 and actions/runner-images#10767).

On the short term, I think we should merge your fix, but I also think that using ubuntu-latest makes more sense in the long term, once the problem is fixed on the github CI.

@almet
Copy link
Contributor

almet commented Oct 17, 2024

You can actually follow the actual discussion here: actions/runner-images#10636

@almet
Copy link
Contributor

almet commented Oct 17, 2024

but I also think that using ubuntu-latest makes more sense in the long term, once the problem is fixed on the github CI.

... Reading the thread actually made me change my mind: we'll be better off with using a specific tag and upgrading it when a new release is out.

As part of checking new releases and adding support for them, we could also bump the image used by our runners to reflect this.

@apyrgio apyrgio merged commit dd3ab71 into main Oct 17, 2024
88 checks passed
@apyrgio apyrgio deleted the 957-gha-runner branch October 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container image builds fail due to older Poetry version
2 participants