Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional tests: remove shell script wrapper #1010

Open
redshiftzero opened this issue Mar 25, 2020 · 2 comments
Open

functional tests: remove shell script wrapper #1010

redshiftzero opened this issue Mar 25, 2020 · 2 comments

Comments

@redshiftzero
Copy link
Contributor

We should investigate if we can remove the shell script wrapper that runs each functional test one at a time. This was introduced due to issues with state being shared between tests, which we should investigate and resolve anyway.

@redshiftzero
Copy link
Contributor Author

Two possibilities (there may be more) to what's causing these test failures:

  1. We're calling QApplication.exit somewhere, causing subsequent tests to fail: QApplication.exit in test makes subsequent tests fail pytest-dev/pytest-qt#37
  2. The pytest-qt docs recommend registering widgets on qtbot (via qtbot.addWidget) such that they are properly closed after test completion, I tried this by registering the main window prior to each test run and it didn't resolve for me though.

@zenmonkeykstop
Copy link
Contributor

To be revisited - functional tests should be capable of being run independently, so this script should not be necessary once that's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Cycle Backlog
Development

No branches or pull requests

2 participants