Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make reply message italic when error #1151

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

sssoleileraaa
Copy link
Contributor

Description

Fixes #1150

WIP until tests are written.

Test Plan

Follow STR in bug report and confirm that we now see "cannot decrypt reply" in italics and a gray status bar.

@eloquence
Copy link
Member

Screenshot from 2020-09-28 15-09-11

👍 Works as expected.

@sssoleileraaa sssoleileraaa force-pushed the style-decrypt-error-replies branch 2 times, most recently from 75b2cc9 to 99534d1 Compare September 29, 2020 22:34
@emkll emkll force-pushed the style-decrypt-error-replies branch from 99534d1 to 9e4e665 Compare September 30, 2020 13:18
@emkll
Copy link
Contributor

emkll commented Sep 30, 2020

rebased on latest main

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @creviera tested a locally-built version of the client package in an sd-app VM in Qubes, works as expected:
italic-reply-error

@@ -7,6 +7,34 @@
padding: 16px;
}

#ReplyWidget_message_pending {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 consolidating the css here makes sense

@sssoleileraaa sssoleileraaa merged commit 7318a35 into main Sep 30, 2020
@sssoleileraaa sssoleileraaa deleted the style-decrypt-error-replies branch September 30, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replies that failed to decrypt not styled
3 participants