Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exporting twice on pressing the Enter key #1241

Merged
merged 1 commit into from
Apr 13, 2021
Merged

fix exporting twice on pressing the Enter key #1241

merged 1 commit into from
Apr 13, 2021

Conversation

sssoleileraaa
Copy link
Contributor

Description

Fixes #1240

Test Plan

  1. Export a file, any file, just press the Enter key (instead of clicking the Continue button) after typing in the password to unlock your luks-encrypted export device.
  2. See that the file is no longer exported twice

Review issue #1240 and see if there are other ways to trigger a double export.

@sssoleileraaa sssoleileraaa requested a review from a team as a code owner April 9, 2021 20:22
@eloquence
Copy link
Member

I will attempt to reproduce the original issue now, and will review if the fix resolves all cases I can reproduce.

@eloquence
Copy link
Member

I'm able to consistently reproduce the double-export by pressing [Enter] on the password dialog, and was only sporadically seeing it before. I guess that identifies me as more of a clicky-clicky user than Conor and Mickael, not that more evidence was needed. ;-) Will now try other mouse/keyboard combos.

@eloquence
Copy link
Member

eloquence commented Apr 9, 2021

As expected, using mouse-only navigation for everything but the passphrase entry results in a single file. Using keyboard-only navigation for everything but the password submit button also results in a single file. Now testing the fix.

@eloquence
Copy link
Member

With the fix in place, I am no longer able to reproduce the issue when using [Enter], and am observing no regressions when using the mouse. This one was pretty elusive, but I think you got it :-)

@sssoleileraaa
Copy link
Contributor Author

Thanks for taking it out for a spin!

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @creviera changes look good to me visually, went through the test plan and no longer observed a double export with these changes.

@emkll emkll merged commit 02b60b3 into main Apr 13, 2021
@emkll emkll deleted the 1238-fix branch April 13, 2021 12:50
@eloquence eloquence mentioned this pull request Aug 4, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submissions are exported twice
3 participants