Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: populate source list immediately upon login (#577) #626

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Nov 19, 2019

Description

Closes #577

I investigated what was going on with #577, turns out it's a fast fix:
the controller's update_sources() method is used to display in the
source list whatever is contained in local storage. If we wait until
after sync_api is called before calling it (what we're doing on master),
there will be a delay of potentially several seconds until the round-trip
to the SecureDrop server completes. In this commit we just call the
update_sources() method immediately upon login.

Test Plan

  1. Reproduce source list is populating very slowly in subsequent runs of the application #577, i.e. confirm the the source list populates slowly (will only happen if you're going over tor)
  2. Check out this branch and login
  3. Confirm the source list appears populated immediately upon login

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

the controller's update_sources() method is used to display in the
source list whatever is contained in local storage. If we wait until
after sync_api is called before calling it, there will be a delay
of potentially several seconds until the round-trip to the SecureDrop
server completes.

in this commit we call the update_sources() method immediately
upon login.
@kushaldas
Copy link
Contributor

Testing this one (after the Qubes update is done).

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirm the source list appears populated immediately upon login

This works as defined in Qubes. Approved.

@kushaldas kushaldas merged commit cb9102e into master Nov 20, 2019
@kushaldas kushaldas deleted the bugfix-577 branch November 20, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source list is populating very slowly in subsequent runs of the application
2 participants