Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Debian bookworm #164

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Migrate to Debian bookworm #164

merged 1 commit into from
Jun 13, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jun 10, 2024

Status

Ready for review

Description of Changes

  • Install poetry from Debian packages
  • Build deployment content in a Debian container instead of Python. This shouldn't make much of a difference except that we'll also get security updates of Python itself from Debian instead of needing to bump the image (which we haven't really been doing).
  • Bump the nginx alpine image to latest.

Refs freedomofpress/securedrop-docs#567.

Testing

  • Run podman build --build-arg GIT_BRANCH=$(git rev-parse HEAD) --file deploy/Dockerfile . -t dev-docs (or docker is fine too), finishes successfully
  • Run podman run --rm -p 5080:5080 dev-docs, visit localhost:5080 in your browser and test basic functionality
    • viewing pages looks fine
    • search works correctly
    • PDF looks good

Release

  • n/a

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

* Install poetry from Debian packages
* Build deployment content in a Debian container instead of Python. This
  shouldn't make much of a difference except that we'll also get
  security updates of Python itself from Debian instead of needing to
  bump the image (which we haven't really been doing).
* Bump the nginx alpine image to latest.

Refs <freedomofpress/securedrop-docs#567>.
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great under Docker. Thanks, @legoktm.

@cfm cfm added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 38f7f49 Jun 13, 2024
4 checks passed
@cfm cfm deleted the bookworm branch June 13, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants