Updated urllib3 from 1.25.8 to 1.25.10 #133
Conversation
| @@ -276,3 +290,7 @@ zipp==2.2.0 \ | |||
| --hash=sha256:5c56e330306215cd3553342cfafc73dda2c60792384117893f3a83f8a1209f50 \ | |||
| --hash=sha256:d65287feb793213ffe11c0f31b81602be31448f38aeb8ffc2eb286c4f6f6657e \ | |||
| # via importlib-metadata | |||
|
|
|||
| # WARNING: The following packages were not pinned, but pip requires them to be | |||
| # pinned when the requirements file includes hashes. Consider using the --allow-unsafe flag. | |||
There was a problem hiding this comment.
👍 for now, see open issue jazzband/pip-tools#989
sssoleileraaa
dismissed
their stale review
even though we agreed it's okay for this test to be failing, let's just cherry-pick to avoid turning off the ci status check
|
https://app.circleci.com/pipelines/github/freedomofpress/securedrop-sdk/134/workflows/d760262f-8e1b-4ae0-b7c5-f23bf08d2208/jobs/1005 and https://app.circleci.com/pipelines/github/freedomofpress/securedrop-sdk/142/workflows/7819bfe4-85f0-402e-82de-e7658010e9b5/jobs/1008 are both fixed by combining this pr commit with the pr commit here: #136 If we just cherry-pick the other commit here then we'll be able to see ci go green. I know it's a little paranoid (and goes against what i said was fine this morning) but it's pretty easy to do |
|
Cherry-picked this commit to get it passing in #136 in order to merge due to merge restrictions. CI is passing there, so closing this PR |
Updates urllib3 dependency from 1.25.8 to 1.25.10 to clear a safety error, and pip-tools to >= 5.0.0 to resolve an incompatibility with the latest pip version.
Testing:
requirements.txtare unchanged