Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

Add support for /users endpoint #134

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Add support for /users endpoint #134

merged 2 commits into from
Oct 13, 2020

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Oct 8, 2020

Description

Resolves #131

Adds support for the /users endpoint.

Status

Ready for review

Test plan

After visual review:

  1. Start an up-to-date development environment
  2. Remove the test-setup.yml and test-get-users.yml cassettes
  3. Re-run tests via make test

Optionally, run the same test in Qubes via a proxy VM (the cassette name to inspect is test_get_users.json).

@eloquence eloquence marked this pull request as ready for review October 9, 2020 20:23
@eloquence
Copy link
Member Author

eloquence commented Oct 9, 2020

This is ready for review. In future we may also want to use the User class to test the /user endpoint, but I suggest we treat that as a separate follow-up PR. I'm noticing a ton of duplication between the HTTP and API proxy tests -- perhaps we can look for ways to refactor this testing logic more cleanly, in the near future. (edit: and of course Jen already opened an issue for that, #67)

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit ce2257b into main Oct 13, 2020
@sssoleileraaa sssoleileraaa deleted the 131-users-endpoint branch October 13, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for /users endpoint
2 participants