Update backup/restore docs with sd-gpg, sd-app backup info #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocodes
force-pushed
the
update-backup-restore-guide
branch
2 times, most recently
from
01da496 to
24800fb
Compare
deeplow
reviewed
Jul 16, 2024
rocodes
force-pushed
the
update-backup-restore-guide
branch
3 times, most recently
from
f5ac4b1 to
7fac1fd
Compare
|
hey @deeplow, thanks for your comments - the PR is now ready for review, and I think I've addressed your changes :) |
nathandyer
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Thanks so much for this @rocodes! Left a few notes about a couple things to tweak, but this is in good shape and I would feel comfortable landing this later today.
revise backup policy: * Back up dom0 directly, instead of copying dom0 configration files to the vault VM. * Include /etc/qubes and /etc/qubes-rpc in dom0 backup (by copying to home directory). * Explain template upgrade for customized VMs and link to upstream docs. * Include sd-gpg secret keys in backup. For most instances, this will be redundant, but for those that have imported an additional (legacy) Submission Private Key, this step is required. * Include instructions for optionally backing up and restoring sd-app. This will allow users to skip the first sync on restoring. * Include caveats and instructions regarding backing up of sensitive information.
rocodes
force-pushed
the
update-backup-restore-guide
branch
from
7fac1fd to
b2c08c5
Compare
|
Hey @nathandyer thanks for the detailed feedback, and sorry for my late-night typos. Changes addressed in b2c08c5 |
nathandyer
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update backup/restore guide with information about backing up sd-app and sd-gpg
(Will clean up and mark ready shortly)